Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 2 | Book-library#345
Closed
Fares-Bakhet wants to merge 4 commits intoCodeYourFuture:mainfrom
Closed
Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 2 | Book-library#345Fares-Bakhet wants to merge 4 commits intoCodeYourFuture:mainfrom
Fares-Bakhet wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
Fares-Bakhet
added
📅 Sprint 2
cjyuan
reviewed
Dec 8, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
Fares-Bakhet
added
Needs Review
cjyuan
reviewed
Dec 9, 2025
Comment on lines
+94
to
+68
| <script src="script.js"></script> | ||
| <script type="module"> | ||
| class Book { | ||
| constructor(title, author, pages, read) { | ||
| this.title = title; | ||
| this.author = author; | ||
| this.pages = pages; | ||
| this.read = read; | ||
| } | ||
| } | ||
|
|
||
| const library = [ | ||
| new Book("Robinson Crusoe", "Daniel Defoe", 252, true), | ||
| new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true) | ||
| ]; |
Contributor
There was a problem hiding this comment.
Why keep the JS code in this HTML file? Should I be reviewing the code in the HTML file or those in script.js?
cjyuan
added
Reviewed
Fares-Bakhet
added
Needs Review
cjyuan
reviewed
Dec 16, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look great. Just one question.
Comment on lines
+58
to
+59
| <td>${book.title}</td> | ||
| <td>${book.author}</td> |
Contributor
There was a problem hiding this comment.
Can you suggest an approach to combat special characters such as '<' and '&' that may exist in a book title? If these characters are not handled properly, they may ruin the display.
Contributor
There was a problem hiding this comment.
You could also write a function to escape the special characters in the string. (Just ask AI. The function is just a few lines of code).
Then you would be able to express something like:
`...
<td>${escape(book.title)}</td>
<td>${escape(book.author)}</td>
...
`
This way, you can keep using your approach to construct the elements.
cjyuan
added
Reviewed
Fares-Bakhet
added
Needs Review
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Complete the book library adjustments.
Questions
No questions.